-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculation of quality metrics based on HUPO-PSI/mzQC definitions #204
Comments
Now, that's a comprehensive list ;) I would suggest to have these in a separate package (maybe The other main question is: what would be the user interface you envision? One function for each QC parameter? Or one main function and define the which metric(s) to calculate with a parameter? One possibility could be: setMethod("quality", "Spectra", function(object, metric = qualityMetrics("Spectra"))) What the method returns depends a little on how the metric is calculated, if it's done on a single spectrum or on the whole
just an idea... |
Great, then let's go for a separate package. Should I create a repo in my repo and start with the implementation there? I guess I can start from next week on to write some functions for calculating (some of) the metrics. We could also start first on the metrics based on I like the idea of having one main function and define the metrics to calculate therein and have for The output would be a |
I would suggest you create a repo under your account - if you want you can eventually add me as external collaborator so that I can review your pull requests? It's sometimes not bad to get a second opinion on implementations... |
Just FYI - there is (or was, as it may have been depreciated) an |
Hi @lgatto thanks for your comment. I checked now, if there is a |
You should also always check if a package name could have an ambiguous meaning or might be offending - in your case I could only find MSQC = Missouri Start Quilt Company - so it should be fine ;) |
sorry, my comment was not really helpful - I just found it funny when I stumbled across that abbreviation |
Beware of MSQC of CRAN. Package names aren't case sensitive, so that one is taken. And the one I was thinking about is proteoQC, that is now deprecated, so also taken. |
Dear @jorainer
following up on the conversation in the slack channel, here comes the issue in the
Spectra
package.The idea was to be able to calculate HUPO-PSI-defined quality metrics (https://github.com/HUPO-PSI/mzQC/blob/master/cv/qc-cv.obo) on MS samples and possibly, for some of them, the
Spectra
package or infrastructure would be an ideal place (or aSpectraQC/...
package). The metrics could be applied on metabolomics and proteomics data. Not all metrics can be calculated based onSpectra
objects.I was thinking of the following, excessive list of, metrics (focusing on MS1, given are the ID, the value type, the name and definition if it differs from the name):
What do you think would be the best place to calculate these metrics (within
Spectra
or outside/in a stand-alone package)? Do you think there could be other objects that could complementSpectra
objects for the calculation when information stored in aSpectra
object is not suitable for the calculation, e.g.QFeatures
?Best,
T.
The text was updated successfully, but these errors were encountered: