You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In PR #259, I included a message about mz being sorted. As pointed by @sgibb, we haven't done so in other instances, and I suppose it doesn't bring much anyway given that a vector logical is always returned, irrespective of the number of contained mz values.
I thought it would be useful to have another function (or update that one) to check for one or multiple contaminants in a Spectra object, something like this
I imagine a function contaminantMz(x, mz = c(...)) that returns a logical matrix of dimensions length(x) by length(mz).
Referring back to this comment, in this case, I thought it would be worth mentioning that mz would be sorted if they weren't. But even here, if we name our colnames, it might not even be needed.
The text was updated successfully, but these errors were encountered:
Here's a two suggestions to implement what is needed for the above feature using containsMz():
Add a simplity argument
The (default) would be simplify = TRUE that would retain the current behaviour while simplify = FALSE would return a matrix of logicals of dimensions length(object) by length(mz) with colnames equal to the (sorted) as.character(mz) indicating whether the given mz is contained in the respective spectra.
Add a what argument
This new argument could take one of "any", "all" value returning respectively the default vector and the matrix of logicals described above. It could possible also take a "which" value to return the index of the contained (sorted) mz.
This would actually be very confusing with the current which argument, so I suggest to ignore this suggestion. Or we repurpuse which.
In PR #259, I included a message about mz being sorted. As pointed by @sgibb, we haven't done so in other instances, and I suppose it doesn't bring much anyway given that a vector logical is always returned, irrespective of the number of contained mz values.
I thought it would be useful to have another function (or update that one) to check for one or multiple contaminants in a
Spectra
object, something like thisI imagine a function
contaminantMz(x, mz = c(...))
that returns a logical matrix of dimensions length(x) by length(mz).Referring back to this comment, in this case, I thought it would be worth mentioning that mz would be sorted if they weren't. But even here, if we name our colnames, it might not even be needed.
The text was updated successfully, but these errors were encountered: