-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle passing/initialization of reference to matchms environment #13
Comments
What I've seen so far in other packages is that they call the I totally agree that using different versions of matchms would be problematic - but here I trust the user - these function should only be for the advanced user, and they, hopefully, know what they are doing. I am not in favour of a global variable, because that might prevent us from using parallel processing (well, question is also if we would really want to do that...). |
Well we can export the variable to the compute cluster, right? Or is that one of the things the biocparallel package can't do? I have the vague memory that there was something like that. |
it depends on the cluster setup - if it has shared memory or not (on Windows, i.e. with socket-based clustering, there is no shared memory). |
I think having a function that populates a global variable might be the best way?
I don't think that passing the reference to the imported matchms is a good thing - this implies you could use different versions of matchms in a single session etc., which is not very clean.
But we can figure out how to do this properly in another issue.
Originally posted by @hechth in #10 (comment)
The text was updated successfully, but these errors were encountered: