-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to remove jruby support #393
Comments
I do not see JRuby in the github action tests.yml. What is the GitHub Action you are referencing? |
That what i said ! We are not testing it. however we have code like this. Jruby don't support rails 7.1 and this gem current release require ~> 7.1.0 |
I would not act on it until there is a real need (e.g. some jruby user is complaining, or the jruby code is generating failures in the main codebase) |
@BuonOmo , it not possible to install this gem with jruby. This is misleading in the readme. |
@seuros thanks for looking into that. Do you know if this new with ActiveRecord >7? |
@keithdoggett, 7.1 is not released: https://github.com/jruby/activerecord-jdbc-adapter. I could not make this adapter work with jruby and rails 7.0 either. |
@seuros got it thanks for that. It looks like it should be working for ActiveRecord 7.0 and 7.1 is under development. Do you have any idea why it's not working for 7.0 since it should be supported? Do we need to bump the version of the adapter? |
We should consider removing JRuby code from the GitHub Action as it is currently untested, and Rails 7.1 lacks official support.
It's unclear if there's active JRuby utilization.
The text was updated successfully, but these errors were encountered: