Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No configs for official species names #4249

Closed
mrgriffin opened this issue Mar 6, 2024 · 2 comments
Closed

No configs for official species names #4249

mrgriffin opened this issue Mar 6, 2024 · 2 comments
Labels
bug Bug status: unconfirmed This bug has not been reproduced yet
Milestone
1.9.0

Comments

@mrgriffin
Copy link
Collaborator

mrgriffin commented Mar 6, 2024 •
edited
Loading

Description

We have B_EXPANDED_MOVE_NAMES and B_EXPANDED_ABILITY_NAMES, but not a P_EXPANDED_SPECIES_NAMES.

tbf, I think P_EXPANDED_SPECIES_NAMES should probably just be a check against the length of POKEMON_NAME_LENGTH, because this means that if somebody increases POKEMON_NAME_LENGTH to 12 (which is something #3438 supports) they'd automatically get the official species names instead of our unofficial ones.

Version

master (default when pulling, unreleased bugfixes)

Upcoming/master Version

No response

Discord contact info

No response
@mrgriffin mrgriffin added bug Bug status: unconfirmed This bug has not been reproduced yet labels Mar 6, 2024
@mrgriffin mrgriffin changed the title No configs for expanded species names No configs for official species names Mar 6, 2024
@mrgriffin mrgriffin added this to the 1.9.0 milestone Mar 6, 2024
@mrgriffin
Copy link
Collaborator Author

Will be fixed by #4241.

@mrgriffin mrgriffin mentioned this issue Apr 25, 2024
Merged
@Bassoonian
Copy link
Collaborator

Fixed by #4241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug status: unconfirmed This bug has not been reproduced yet
Projects
None yet
Milestone
1.9.0
Development

No branches or pull requests
2 participants
@mrgriffin @Bassoonian