Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMakeLists.txt creates directories out of the build directory #96

Open
kdudka opened this issue Mar 24, 2016 · 0 comments
Open

CMakeLists.txt creates directories out of the build directory #96

kdudka opened this issue Mar 24, 2016 · 0 comments
Assignees
@mruprich

Comments

@kdudka
Copy link

kdudka commented Mar 24, 2016

The CMake script should not write to file system out of the build directory. IMO the following two lines are inappropriate for a script that is supposed to be run by trustful developers:

file(MAKE_DIRECTORY /tmp/ssds/)
file(MAKE_DIRECTORY /var/cache/ssds/packages/)

https://github.com/rh-lab-q/server-side-dependency-solving/blob/fb901f3e1c89b90b9d08b8a3ecc183c9e6ada45a/CMakeLists.txt#L196
@mruprich mruprich self-assigned this Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mruprich mruprich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kdudka @mruprich