Skip to content

Commit 875a3e1

Browse files
committed
RH2020290: Support TLS 1.3 in FIPS mode
Revert e8b5bf9 in in SSLContextImpl.java and SunJSSE.java: ~~~ git show e8b5bf9 | git apply -R --include=src/java.base/share/classes/sun/security/ssl/* ~~~ Backport-Of: rh-openjdk/jdk@0bd5ca9
1 parent 0cb2359 commit 875a3e1

File tree

2 files changed

+15
-61
lines changed

2 files changed

+15
-61
lines changed

src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java

Lines changed: 13 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import java.security.cert.*;
3232
import java.util.*;
3333
import javax.net.ssl.*;
34-
import jdk.internal.misc.SharedSecrets;
3534
import sun.security.action.GetPropertyAction;
3635
import sun.security.provider.certpath.AlgorithmChecker;
3736
import sun.security.validator.Validator;
@@ -543,38 +542,20 @@ private abstract static class AbstractTLSContext extends SSLContextImpl {
543542

544543
static {
545544
if (SunJSSE.isFIPS()) {
546-
if (SharedSecrets.getJavaSecuritySystemConfiguratorAccess()
547-
.isSystemFipsEnabled()) {
548-
// RH1860986: TLSv1.3 key derivation not supported with
549-
// the Security Providers available in system FIPS mode.
550-
supportedProtocols = Arrays.asList(
551-
ProtocolVersion.TLS12,
552-
ProtocolVersion.TLS11,
553-
ProtocolVersion.TLS10
554-
);
555-
556-
serverDefaultProtocols = getAvailableProtocols(
557-
new ProtocolVersion[] {
558-
ProtocolVersion.TLS12,
559-
ProtocolVersion.TLS11,
560-
ProtocolVersion.TLS10
561-
});
562-
} else {
563-
supportedProtocols = Arrays.asList(
564-
ProtocolVersion.TLS13,
565-
ProtocolVersion.TLS12,
566-
ProtocolVersion.TLS11,
567-
ProtocolVersion.TLS10
568-
);
545+
supportedProtocols = Arrays.asList(
546+
ProtocolVersion.TLS13,
547+
ProtocolVersion.TLS12,
548+
ProtocolVersion.TLS11,
549+
ProtocolVersion.TLS10
550+
);
569551

570-
serverDefaultProtocols = getAvailableProtocols(
571-
new ProtocolVersion[] {
572-
ProtocolVersion.TLS13,
573-
ProtocolVersion.TLS12,
574-
ProtocolVersion.TLS11,
575-
ProtocolVersion.TLS10
576-
});
577-
}
552+
serverDefaultProtocols = getAvailableProtocols(
553+
new ProtocolVersion[] {
554+
ProtocolVersion.TLS13,
555+
ProtocolVersion.TLS12,
556+
ProtocolVersion.TLS11,
557+
ProtocolVersion.TLS10
558+
});
578559
} else {
579560
supportedProtocols = Arrays.asList(
580561
ProtocolVersion.TLS13,
@@ -639,16 +620,6 @@ boolean isDTLS() {
639620

640621
static ProtocolVersion[] getSupportedProtocols() {
641622
if (SunJSSE.isFIPS()) {
642-
if (SharedSecrets.getJavaSecuritySystemConfiguratorAccess()
643-
.isSystemFipsEnabled()) {
644-
// RH1860986: TLSv1.3 key derivation not supported with
645-
// the Security Providers available in system FIPS mode.
646-
return new ProtocolVersion[] {
647-
ProtocolVersion.TLS12,
648-
ProtocolVersion.TLS11,
649-
ProtocolVersion.TLS10
650-
};
651-
}
652623
return new ProtocolVersion[] {
653624
ProtocolVersion.TLS13,
654625
ProtocolVersion.TLS12,
@@ -978,16 +949,6 @@ private static List<ProtocolVersion> customizedProtocols(
978949

979950
static ProtocolVersion[] getProtocols() {
980951
if (SunJSSE.isFIPS()) {
981-
if (SharedSecrets.getJavaSecuritySystemConfiguratorAccess()
982-
.isSystemFipsEnabled()) {
983-
// RH1860986: TLSv1.3 key derivation not supported with
984-
// the Security Providers available in system FIPS mode.
985-
return new ProtocolVersion[] {
986-
ProtocolVersion.TLS12,
987-
ProtocolVersion.TLS11,
988-
ProtocolVersion.TLS10
989-
};
990-
}
991952
return new ProtocolVersion[]{
992953
ProtocolVersion.TLS13,
993954
ProtocolVersion.TLS12,

src/java.base/share/classes/sun/security/ssl/SunJSSE.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@
2727

2828
import java.security.*;
2929
import java.util.*;
30-
31-
import jdk.internal.misc.SharedSecrets;
3230
import sun.security.rsa.SunRsaSignEntries;
3331
import static sun.security.util.SecurityConstants.PROVIDER_VER;
3432
import static sun.security.provider.SunEntries.createAliases;
@@ -197,13 +195,8 @@ private void doRegister(boolean isfips) {
197195
"sun.security.ssl.SSLContextImpl$TLS11Context", null, null);
198196
ps("SSLContext", "TLSv1.2",
199197
"sun.security.ssl.SSLContextImpl$TLS12Context", null, null);
200-
if (!SharedSecrets.getJavaSecuritySystemConfiguratorAccess()
201-
.isSystemFipsEnabled()) {
202-
// RH1860986: TLSv1.3 key derivation not supported with
203-
// the Security Providers available in system FIPS mode.
204-
ps("SSLContext", "TLSv1.3",
205-
"sun.security.ssl.SSLContextImpl$TLS13Context", null, null);
206-
}
198+
ps("SSLContext", "TLSv1.3",
199+
"sun.security.ssl.SSLContextImpl$TLS13Context", null, null);
207200
ps("SSLContext", "TLS",
208201
"sun.security.ssl.SSLContextImpl$TLSContext",
209202
(isfips? null : createAliases("SSL")), null);

0 commit comments

Comments
 (0)