Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shim-15.6 for ZeronsoftN #254

Closed
8 tasks done
joseph-zeronsoftn opened this issue Jun 27, 2022 · 6 comments
Closed
8 tasks done

shim-15.6 for ZeronsoftN #254

joseph-zeronsoftn opened this issue Jun 27, 2022 · 6 comments
Labels
bug Problem with the review that must be fixed before it will be accepted contact verification needed Contact verification is needed for this review

Comments

@joseph-zeronsoftn
Copy link

joseph-zeronsoftn commented Jun 27, 2022

Confirm the following are included in your repo, checking each box:

  • completed README.md file with the necessary information
  • shim.efi to be signed
  • public portion of your certificate(s) embedded in shim (the file passed to VENDOR_CERT_FILE)
  • binaries, for which hashes are added to vendor_db ( if you use vendor_db and have hashes allow-listed )
  • any extra patches to shim via your own git tree or as files
  • any extra patches to grub via your own git tree or as files
  • build logs
  • a Dockerfile to reproduce the build of the provided shim EFI binaries

What is the link to your tag in a repo cloned from rhboot/shim-review?


https://github.com/zeronsoftn/shim-review/tree/zeronsoftn-shim-x86_64-20220627


What is the SHA256 hash of your final SHIM binary?


473133c16e9ae07f3d27c5f4e7968da57b6fdbf893b77eb329269f3925e92106  shimaa64.efi
d7f4c74156264b3848b82352c0284107f37d09776f1eb0448dc575c8b876d7c4  shimia32.efi
f19621c78390a3a0464930522d85683e47ade0e4fd691a8c2c8d6ced6fe7282f  shimx64.efi

Previous submissions: #147

@joseph-zeronsoftn joseph-zeronsoftn changed the title shim-15.6 for ZeronsoftN Draft: shim-15.6 for ZeronsoftN Jun 27, 2022
@joseph-zeronsoftn joseph-zeronsoftn changed the title Draft: shim-15.6 for ZeronsoftN shim-15.6 for ZeronsoftN Jun 27, 2022
@frozencemetery frozencemetery added the contact verification needed Contact verification is needed for this review label Aug 15, 2022
@frozencemetery
Copy link
Member

frozencemetery commented Aug 15, 2022

Your contact information has changed - it would have been helpful to call this out. Why does Joseph Lee have a new key?

@frozencemetery frozencemetery added the question Reviewer(s) waiting on response label Aug 15, 2022
@joseph-zeronsoftn
Copy link
Author

@frozencemetery The key has expired and a new one has been created.

@frozencemetery
Copy link
Member

Okay, but why did you do that instead of renewing the expired key?

@joseph-zeronsoftn
Copy link
Author

@frozencemetery Actually, there is no big reason. I thought it was not good to use the same key for a long time.

@steve-mcintyre
Copy link
Collaborator

@frozencemetery are you going to look at this review again?

@frozencemetery
Copy link
Member

Please note #307

@frozencemetery frozencemetery added bug Problem with the review that must be fixed before it will be accepted and removed question Reviewer(s) waiting on response labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problem with the review that must be fixed before it will be accepted contact verification needed Contact verification is needed for this review
Projects
None yet
Development

No branches or pull requests

3 participants