-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shim-15.7 (NX Patched) for ZeronsoftN #343
Comments
Review
|
@THS-on Thank you! :) https://github.com/zeronsoftn/shim-review/tree/zeronsoftn-shim-x86_64_ia32_aarch64-20231017
|
I see that you pulled the Debian patches for enabling lockdown. To actually enable them you'll also need to set |
@THS-on Thank you! I missed it.. This is the commit applied: zeronsoftn/alpine-pkg-kernel@3df6633 |
The shim for For systemd stub, we are waiting for a review of the upstream code before accepting submissions including it. Besides that this needs also one more (also unofficial) review, to check that we haven't missed anything. |
Hello. |
Hello. Apologies for the delay - reviewing as much as I can. I won't be able to review systemd-boot by myself and can't base on the earlier accepted application. Apologies, but you'll have to wait for someone, who can. In the meantime certain requirements have changed and some information will have to be updated. Below are the entries I spotted. As far as I can see this is the current implementation in Debian's Shim SBAT has not been updated in the Is the whole bootchain NX-compatible? Since I have no experience with systemd-boot, I can't tell anything on this one, but for the current GRUB2 and kernel versions I have some doubts. The https://github.com/zeronsoftn/shim-release repository seems to be empty, despite being mentioned as part of Shim's SBAT. Is this intentional? Am I missing something? |
@joseph-zeronsoftn can you either update this submission to 15.8 or create a new one? |
Confirm the following are included in your repo, checking each box:
What is the link to your tag in a repo cloned from rhboot/shim-review?
https://github.com/zeronsoftn/shim-review/tree/zeronsoftn-shim-x86_64_ia32_aarch64-20230915https://github.com/zeronsoftn/shim-review/tree/zeronsoftn-shim-x86_64_ia32_aarch64-20231017
What is the SHA256 hash of your final SHIM binary?
What is the link to your previous shim review request (if any, otherwise N/A)?
#147 (accepted)
Help to review
jc-lab/shim-review-bot#3 (comment)jc-lab/shim-review-bot#3 (comment)
The text was updated successfully, but these errors were encountered: