-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing removal of mocks from forge-std v1.9.6 #181
Comments
@kopy-kat to address this, I think we can integrate OpenZeppelin's or Solady's ERC20Mock by including these mocks in packages or by adding sources locally/writing our own contract within modulekit. What do you suggest? |
I think going with solady would make sense |
It looks like Solady’s published package does not include mocks by default, and other similar packages based on Solady also exclude them. This method works, but it pulls in the entire Solady repository into the lib folder, even though we only need the mock contracts. This significantly increases the project’s size. |
yeah good point. I agree, copying over the mock erc20 seems like the best idea in that case |
Sounds good, pushing this |
Raised PR here: #182 |
Have you ensured that all of these are up to date?
package.json
)What command(s) is the bug in?
run pnpm test after running pnpm up
Operating System
Any
Describe the bug
As part of v.1.9.6 through this PR, forge-std deprecate MockERC20.sol and MockERC721 (among other things) which we leverage in some tests
The text was updated successfully, but these errors were encountered: