-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update versions in bundle generation #411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielmellado, jan--f The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We missed updating to the new prometheus-operator version in the bundle. Additionally this sets the new `--images` cli args for the operator deployment. Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
11de259
to
2d05f65
Compare
Since we pass this explicitly in the bundle now, the field is set during the test. Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We missed updating to the new prometheus-operator version in the bundle. Additionally this sets the new
--images
cli args for the operator deployment.