Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update versions in bundle generation #411

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

jan--f
Copy link
Collaborator

@jan--f jan--f commented Jan 23, 2024

We missed updating to the new prometheus-operator version in the bundle. Additionally this sets the new --images cli args for the operator deployment.

@jan--f jan--f requested a review from a team as a code owner January 23, 2024 14:12
@jan--f jan--f requested review from danielmellado and slashpai and removed request for a team January 23, 2024 14:12
@openshift-ci openshift-ci bot requested a review from simonpasquier January 23, 2024 14:12
Copy link
Contributor

@danielmellado danielmellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, jan--f

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielmellado,jan--f]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

We missed updating to the new prometheus-operator version in the bundle.
Additionally this sets the new `--images` cli args for the operator
deployment.

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Jan 23, 2024
Since we pass this explicitly in the bundle now, the field is set during
the test.

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 23, 2024
@jan--f jan--f merged commit 755caba into rhobs:main Jan 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants