Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Korrel8r backend creation when the troubleshooting panel is deployed #497

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Korrel8r backend creation when the troubleshooting panel is deployed #497

merged 1 commit into from
Jun 7, 2024

Conversation

shwetaap
Copy link
Contributor

Korrel8r backend deployments get created when the troubleshooting panel is created. Uses the same controller as the Troubleshooting panel to setup the backend Korrel8r components. Closing the previous draft PR in favor of this approach - #474

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 31, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@shwetaap shwetaap mentioned this pull request May 31, 2024
Closed
@shwetaap shwetaap changed the title Korrel8r backend deployments get created when the troubleshooting panel is created Korrel8r backend creation when the troubleshooting panel is deployed May 31, 2024
alanconway
alanconway approved these changes Jun 1, 2024
View reviewed changes
Copy link

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few minor comments but none to hold up the PR.

cmd/operator/main.go Outdated Show resolved Hide resolved
pkg/controllers/uiplugin/components.go Outdated Show resolved Hide resolved
pkg/controllers/uiplugin/config/korrel8r.yaml Outdated Show resolved Hide resolved
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 1, 2024

@alanconway: changing LGTM is restricted to collaborators

In response to this:

Looks good, a few minor comments but none to hold up the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shwetaap shwetaap marked this pull request as ready for review June 5, 2024 06:17
@shwetaap shwetaap requested a review from a team as a code owner June 5, 2024 06:17
@shwetaap shwetaap requested review from simonpasquier and sthaha and removed request for a team June 5, 2024 06:17
@openshift-ci openshift-ci bot requested a review from jan--f June 5, 2024 06:17
@danielmellado
Copy link
Contributor

@shwetaap would you mind rebasing this? thanks

@periklis periklis mentioned this pull request Jun 5, 2024
Merged
@shwetaap shwetaap force-pushed the COO-korrel8r branch 2 times, most recently from 367034c to 7fd1b64 Compare June 5, 2024 18:39
@shwetaap shwetaap force-pushed the COO-korrel8r branch 3 times, most recently from e1081b0 to cf4e4cd Compare June 6, 2024 06:08
@shwetaap shwetaap force-pushed the COO-korrel8r branch 2 times, most recently from 1b83cca to 665cb67 Compare June 6, 2024 17:31
periklis
periklis requested changes Jun 6, 2024
View reviewed changes
pkg/controllers/uiplugin/components.go Outdated Show resolved Hide resolved
pkg/controllers/uiplugin/plugin_info_builder.go Outdated Show resolved Hide resolved
@shwetaap
feat: add Korrel8r plugin to UITroubleshootPanel
82594f8 
Signed-off-by: Shweta Padubidri <spadubid@redhat.com>
@openshift-ci openshift-ci bot added the lgtm label Jun 7, 2024
@periklis
Copy link

periklis commented Jun 7, 2024

/lgtm

1 similar comment
@danielmellado
Copy link
Contributor

/lgtm

@danielmellado
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, danielmellado, periklis, shwetaap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 02690af into rhobs:main Jun 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremes tremes tremes left review comments

@danielmellado danielmellado danielmellado left review comments

@jgbernalp jgbernalp jgbernalp left review comments

@alanconway alanconway alanconway approved these changes

@periklis periklis periklis approved these changes

@simonpasquier simonpasquier Awaiting requested review from simonpasquier simonpasquier is a code owner automatically assigned from rhobs/observability-operator-maintainers

@sthaha sthaha Awaiting requested review from sthaha sthaha is a code owner automatically assigned from rhobs/observability-operator-maintainers

@jan--f jan--f Awaiting requested review from jan--f

Assignees

@periklis periklis

@danielmellado danielmellado

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shwetaap @danielmellado @periklis @tremes @jgbernalp @alanconway @openshift-merge-robot