COO-261: Support tolerations and nodeselector in Monitoringstack

[PaulFarver]

Add support for tolerations and nodeselectors in the monitoringstack CRD.

[openshift-ci]

Hi @PaulFarver. Thanks for your PR.

I'm waiting for a rhobs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[simonpasquier]

/ok-to-test
/retitle COO-261: Support tolerations and nodeselector in Monitoringstack

[openshift-ci-robot]

@PaulFarver: This pull request references COO-261 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

Add support for tolerations and nodeselectors in the monitoringstack CRD.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[simonpasquier]

Thanks for the PR! Commit messages need to start with feat: ... or chore: .... There's also an issue with the generated code not being up-to-date apparently.

[PaulFarver]

@simonpasquier thanks for looking at this :)

I've updated the commit messages, but I'm unsure what to do about the generated code. When I run make generate the output is what's in the current PR

[simonpasquier]

Yeah, the code generation can be tricky sometimes. Can you try running make --always-make generate bundle? Otherwise I can probably push the required changes to your branch.

[simonpasquier]

You'd need also to amend the commit messages to remove the upper-case after the : .

[PaulFarver]

Yeah. It should be updated now

[simonpasquier]

/lgtm
/approve

Thanks!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PaulFarver, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[simonpasquier]

I pushed onto your branch the updated version of bundle/manifests/observability-operator.clusterserviceversion.yaml.

[simonpasquier]

/lgtm