Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COO-152: fix: Add finalizer to cleanup the console after UIPlugin is deleted #576

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

jgbernalp
Copy link
Contributor

This PR

  • Extracts the plugin console names into a map, so the console name can be obtained from the plugin type
  • Adds a finalizer to the UIPlugin so it can be removed from console resource when the plugin is deleted, it uses the console name from the map to do so

@jgbernalp jgbernalp requested a review from a team as a code owner September 26, 2024 08:03
@jgbernalp jgbernalp requested review from simonpasquier and JoaoBraveCoding and removed request for a team September 26, 2024 08:03
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 26, 2024

@jgbernalp: This pull request references COO-152 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

This PR

  • Extracts the plugin console names into a map, so the console name can be obtained from the plugin type
  • Adds a finalizer to the UIPlugin so it can be removed from console resource when the plugin is deleted, it uses the console name from the map to do so

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jan--f and marioferh September 26, 2024 08:03
Copy link

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@jgbernalp jgbernalp force-pushed the add-uiplugin-finalizer branch from cfc4443 to 48a4338 Compare September 26, 2024 08:05
@jan--f
Copy link
Collaborator

jan--f commented Sep 30, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4ce18d9 into rhobs:main Sep 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants