Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss tools setup for CI #241

Open
jan--f opened this issue Jan 5, 2023 · 3 comments
Open

Discuss tools setup for CI #241

jan--f opened this issue Jan 5, 2023 · 3 comments

Comments

@jan--f
Copy link
Collaborator

jan--f commented Jan 5, 2023

Currently the tools we need for CI have no defined install policy. For some tools we install specific versions and make sure that version is used. For other tools we install latest or similar and sometimes check that the version we want is actually executed. I.e. for some tools the version is never actually checked.
Currently the main purpose of the versions defined in Makefile.tools is to cache tools for github actions and update the cache if necessary. This topic came up in #239.

We should agree on a policy to either pin specific version or use latest.

@simonpasquier
Copy link
Contributor

My 2 cents: I'm usually in favor of using pinned versions as it guarantees better reproducibility and avoids unattended breakages.

@JoaoBraveCoding
Copy link
Contributor

I agree with Simon on this one 👍

@sthaha
Copy link
Collaborator

sthaha commented Jan 8, 2023

Agree with Simon. Pinning allows reproducibility and consistency across all envs (dev, ci, ..). The additional benefit is that we cache the tools and thereby close to zero transient errors because of network issues.

We do need a periodic task to upgrade the tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants