Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make commit-lint target to help contributor validate commit message locally before submitting #305

Open
sthaha opened this issue Jun 28, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@sthaha
Copy link
Collaborator

sthaha commented Jun 28, 2023

Often PRs are blocked because the commit-lint action fails - e.g. #304 fails
because of commit-lint https://github.com/rhobs/observability-operator/actions/runs/5377063687/jobs/9760871220

It would reduce rework and toil if we provided a make target - commit-lint which allows contributors to validate commit messages locally.

It does help if all they have to run is make lint to ensure all lints are caught before submission.

@slashpai slashpai added the good first issue Good for newcomers label Jun 28, 2023
@wasup-yash
Copy link

wasup-yash commented Aug 12, 2024

COMMIT_MSG_FILE=.git/COMMIT_EDITMSG

COMMITLINT=commitlint

lint-commit:
@echo "Running commit lint..."
@$(COMMITLINT) -e $$($(COMMIT_MSG_FILE))

we want something like this right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants