Check if collection is empty before trying to manipulate first element. #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rianjs
approved these changes
Sep 19, 2017
There was a problem hiding this comment.
In the future, can you make a parallel change to v2?
Also, you can express this more concisely:
if (ContainsKey(group))
{
AllOf(group)?.FirstOrDefault()?.SetValue(values);
return;
}I'll merge and make the parallel change in v2, and tighten up the expression of the idea.
Thanks for the fix!
rianjs
pushed a commit
that referenced
this pull request
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the InvalidOperationException mentioned in #311.
I assume that it is the correct behaviour, that it simply reappends the product id property.