Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dorling option for proportional symbols #77

Closed
rysebaert opened this issue Jul 6, 2022 · 5 comments · Fixed by #97
Closed

Dorling option for proportional symbols #77

rysebaert opened this issue Jul 6, 2022 · 5 comments · Fixed by #97
Labels
enhancement Discussions about possible improvements
Milestone

Comments

@rysebaert
Copy link
Member

add Dorling option for maps with proportional symbols, to avoid overlapping > would require an additional parameter (number of iterations)
magrit2

@rysebaert rysebaert added the enhancement Discussions about possible improvements label Jul 6, 2022
@mthh mthh added this to the 0.9.0 milestone Aug 24, 2022
@mthh mthh modified the milestones: 0.9.0, 0.10.0 Aug 31, 2022
@mthh mthh modified the milestones: 0.10.0, 0.11.0 Oct 7, 2022
@mthh
Copy link
Member

mthh commented Oct 19, 2022

I have a first almost complete implementation (the simulation is restarted if the user changes the cartographic projection but I still have some details to fix to restart the simulation when the user changes the symbol size or the symbol border size)

What do you think about not asking for the number of iterations when creating the layer (and that this number can then be modified in the layer properties popup)?
Cf. screenshot below of what I propose.

Layer creation options :

layer_creation

Layer properties popup :

popup_style

@neocarto
Copy link
Member

Ok with that

@rCarto
Copy link
Member

rCarto commented Oct 19, 2022

Ok for me + we should add a reference to the algorithm in documentation (that explain iterations).

@mthh
Copy link
Member

mthh commented Oct 19, 2022

we should add a reference to the algorithm in documentation (that explain iterations).

Yes sure !

I chose not to refer to Dorling / Demers here (to have the same "avoid overlap" setting for square and circle and to avoid needing special cartographic knowledge when the user just wants to "avoid overlaps") and save that for the documentation.

However we could already have some info about this in a tooltip (so that the user knows that increasing the number of iterations is supposed to improve the result)?

@rCarto
Copy link
Member

rCarto commented Oct 19, 2022

However we could already have some info about this in a tooltip (so that the user knows that increasing the number of iterations is supposed to improve the result)?

That would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Discussions about possible improvements
Development

Successfully merging a pull request may close this issue.

4 participants