-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork with browser support #5
Comments
Thank you @catdevnull ! @ribose-jeffreylau could you see if we can port back the changes via a PR? Thanks! |
@catdevnull I completely failed to notice this as I did a refactor that aims to remove the Node dependency. My refactor happened independently of yours but I’m happy to see the similarities in our approaches. Like you, I decided to adopt the same approach as in isomorphic-git of accepting an Can probably expect this library to be as isomorphic as isomorphic-git in version 0.2.0 planned to be released later this month after some testing. |
There may be a breaking change in 0.2.0 as I want the lower-level (but nevertheless publicly exported) utility |
it's most certainly "the right thing to do"; i just wanted to get it with the least amount of effort working enough for my use case in which bundle size doesn't matter. considering that the buffer package uses Uint8Array internally i'm guessing it's not going to worsen performance. |
:') yes, also, my work might not be very PR-able because i changed a lot of the tooling and indentation around. |
@catdevnull can I ask whether you access the |
nope, i don't use |
Hi, I made a fork with hacky browser support. There are some rough edges and it's not fully tested, but it seems to work. https://gitea.nulo.in/Nulo/isogit-lfs
The text was updated successfully, but these errors were encountered: