Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition for rule 'react/jsx-no-duplicate-props' was not found #114

Closed
ricardofbarros opened this issue May 17, 2016 · 17 comments
Closed

Comments

@ricardofbarros
Copy link
Owner

ricardofbarros commented May 17, 2016

Hey @lubien, moving this conversation to here.

This is odd, as this type of bugs were fixed as of 3.3.0 with #101 PR.

Can you give me a small code sample so I can try replicate this?

@lubien
Copy link

lubien commented May 17, 2016

Well, actually I'm using eslint for the project. If you don't mind, I can push to my github.

@ricardofbarros
Copy link
Owner Author

Sure, just drop a link to the raw file.

@lubien
Copy link

lubien commented May 17, 2016

Here. Try going to ./server/app.js

@ricardofbarros
Copy link
Owner Author

Hey @lubien just cloned your repo and did a fresh install and linter-js-standard is working fine. No react/jsx-no-duplicate-props message, could you clean your node_modules dir and do a fresh install?

From what I'm seeing on your project your npm test script is running semistandard, which is getting the global semistandard, that could be why running on your CLI you don't get nothing and when you use linter-js-standard you get an error, possibly because you have an outdated semistandard under your project.

@lubien
Copy link

lubien commented May 17, 2016

Cleaned node_modules and installed again. Nothing changed.
Also using "lint": "./node_modules/.bin/semistandard" still have the empty result.
About the semistandard version. I've installed today, so...

@ricardofbarros
Copy link
Owner Author

Hmm, can you tell me what are the settings you have of linter-js-standard ? Do you have Check for standard ticked?

@lubien
Copy link

lubien commented May 17, 2016

It's like this

@ricardofbarros
Copy link
Owner Author

What's happening is that linter-js-standard is linting with the default linter, I can do version bump on linter-js-standard updating the default versions, but that' something I wish to stay away on the future of this package. It should always get standard, semistandard from node_modules

@jsejcksn
Copy link

jsejcksn commented May 22, 2016

@ricardofbarros I'm having this issue, too. How can I help? I just installed linter-js-standard from inside Atom settings and am using semistandard as the only deviation from the default package settings. I get the error in every JS file at the beginning of the first expression. Does the plugin require a package.json file in the project or any specific string within package.json if it does exist?

@ricardofbarros
Copy link
Owner Author

Hey @jsejcksn, yes linter-js-standard requires a package.json with devDependencies set with standard or semistandard, etc ..

Can you tell me your OS? Is it Win 10 as well ?

@jsejcksn
Copy link

@ricardofbarros I'm using OS X 10.11.5.

@ricardofbarros
Copy link
Owner Author

@jsejcksn do you have the same settings as here, or at least Check for standard ticked?

@jsejcksn
Copy link

@ricardofbarros
linter-js-standard-settings

@ricardofbarros
Copy link
Owner Author

@jsejcksn I'm going to remove the option Check for standard in the future as it should be always enabled, but if you want to use the semistandard version you have installed under your project you should tick that option :) .

@jsejcksn
Copy link

@ricardofbarros Why is a package.json file required? I often use linters with individual files which are not associated with a package and have no package.json file.

@ricardofbarros
Copy link
Owner Author

Well, this is odd. Normally everyone has a package.json on the root of their project while they are editing their files.

But oh well, I'm tired of this issues about Definition react... not found and I'm going to release a patch version with update versions of standard, semistandard and so on.

@ricardofbarros
Copy link
Owner Author

@jsejcksn and @lubien, just released a patch version with updated dependencies. So now you can both update linter-js-standard and you'll have the most recent linters. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants