Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter doesn't seem to be receiving options from package.json #206

Closed
saadq opened this issue Sep 12, 2017 · 2 comments
Closed

Linter doesn't seem to be receiving options from package.json #206

saadq opened this issue Sep 12, 2017 · 2 comments

Comments

@saadq
Copy link

saadq commented Sep 12, 2017

For example, let's say I have this in my package.json file:

{
  "standard": {
    "ignore": ["src/tests"]
  }
}

If I run standard in the command line, I don't get any errors. However, when I open the file in my editor, I still have the errors displayed:

screen shot 2017-09-12 at 4 51 48 pm

I'm on Atom v1.20.0 and using linter-js-standard v4.0.1. Let me know if I can provide any other info.

@sonicdoe
Copy link
Collaborator

Thank you, I was able to reproduce this.

The issue is that minimatch doesn’t match directories (like e.g. .gitignore does). Coincidentally, ESLint had the same issue three years ago. I’ll probably fix this using ignore in the next patch version.

@sonicdoe
Copy link
Collaborator

Should be fixed in v4.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants