Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 - Support Protobuf proto3 / proto2 #644

Closed
afifurrohman-id opened this issue Sep 1, 2024 · 5 comments · Fixed by #645
Closed

🚀 - Support Protobuf proto3 / proto2 #644

afifurrohman-id opened this issue Sep 1, 2024 · 5 comments · Fixed by #645
Labels
feature New feature or request

Comments

@afifurrohman-id
Copy link

Which @codeimage/* package(s) are relevant/releated to the feature request?

codeimage

Description

At least protobuf version 3 (proto3) need to supported
@afifurrohman-id afifurrohman-id added the feature New feature or request label Sep 1, 2024
@riccardoperra
Copy link
Owner

Hi, I need more detailed information about this. What “protobuf” is exactly? It seems something related to python language, which is supported

@afifurrohman-id
Copy link
Author

Hi, I need more detailed information about this. What “protobuf” is exactly? It seems something related to python language, which is supported

No it's grpc related.
It's data serialization: https://protobuf.dev/
Which like json but more lightweight, that's make grpc much faster than REST.

@riccardoperra riccardoperra mentioned this issue Sep 1, 2024
Merged
@riccardoperra riccardoperra linked a pull request Sep 1, 2024 that will close this issue
feat: add support for protobuf #645
Merged
@riccardoperra
Copy link
Owner

Didn't know about something like that 😄 Anyway, i'm opening a PR to support it since fortunately it's already supported by codemirror. Can you confirm to me if protobuf files have ".proto" extension?

Here's a preview
image

@afifurrohman-id
Copy link
Author

Didn't know about something like that 😄 Anyway, i'm opening a PR to support it since fortunately it's already supported by codemirror. Can you confirm to me if protobuf files have ".proto" extension?

Yes, the preview it's awesome btw 🎉

@riccardoperra
Copy link
Owner

Available with 1.7.2 😄 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for protobuf riccardoperra/codeimage
2 participants
@riccardoperra @afifurrohman-id