Package cannot automatically be dropped, but is currently

[richard-uk1]

Quoted

The Package implementation must be changed. It's good that alpm_pkg_load is the only function that return a alpm_pkg_t which must owned but it can't be free automatically via Drop. In fact the common usage is to load a local tarball and then to install it. In the case of a successful install it must not be freed, otherwise it must be freed.
What I would do:

• implement alpm_pkg_load in Transaction in a function which load a tarball and add the returned package to install, this way the package can freed manually in case of failure.
• rename PackageRef as Package for name consistency.
• maybe implement Package as Db with a struct keeping a reference to a alpm_pkg_t

[richard-uk1]

I need to look at this again, but my first thoughts:

Maybe a successful install could take ownership of the package, and then not run the drop (using mem::forget or similar).

[richard-uk1]

I've implemented an approach based on mem::forget. Need to check it works as expected.