Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in algorithm ReportLongMatches? #33

Open
pd3 opened this issue Jun 18, 2015 · 1 comment
Open

Bug in algorithm ReportLongMatches? #33

pd3 opened this issue Jun 18, 2015 · 1 comment

Comments

@pd3
Copy link
Contributor

pd3 commented Jun 18, 2015

The algorithm 3 (pbwt -longWithin 5) does not report some long matches. For example, in the following example:

1:1010001 001100
4:1010001 001100
0:0110000 101010
2:0011000 110010
5:0011001 000010
3:1011001 100100

I would think that a match between the haplotypes 5 and 3 should be reported at k=6 or is my interpretation of a "long match" incorrect?

EDIT: or perhaps 5 and 2 for k=6 and 5 and 3 for k=7, depending if we report at the last matching position or immediately after.

@adrianodemarino
Copy link

I have observed a similar issue where it appears that some matches are not being reported. It seems that the algorithm matchLongWithin2 is not capturing all of the matches. Is there an alternative implementation that addresses this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants