Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize initial import with GridFS #147

Closed
richardwilly98 opened this issue Sep 27, 2013 · 5 comments
Closed

Optimize initial import with GridFS #147

richardwilly98 opened this issue Sep 27, 2013 · 5 comments
Milestone

Comments

@richardwilly98
Copy link
Owner

GridFS.getFileList() return DBObject(s) where GridFSDBFile.getInputStream failed [1].
Due to this issue we currently call an additional GridFSDBFile.findOne()

This code should most likely be optimized [2].

Related to #47

[1] - mongodb/mongo-java-driver#48
[2] - https://github.com/richardwilly98/elasticsearch-river-mongodb/blob/master/src/main/java/org/elasticsearch/river/mongodb/Slurper.java#L145

@richardwilly98
Copy link
Owner Author

Question has been posted here [1].

[1] - https://groups.google.com/forum/#!topic/mongodb-user/1cyufSRfN1I

@benmccann
Copy link
Collaborator

FYI, I'm having a test failing on the current master that might be related to this

Failed tests: testImportPDFAttachment(org.elasticsearch.river.mongodb.gridfs.RiverMongoWithGridFSTest): testImportPDFAttachment failed

@richardwilly98
Copy link
Owner Author

@benmccann the latest build was successful [1].

I have seen by past some issue with unit test due to time to index the document in ES. I have recently changed the time to wait for a document to be indexed from 6 sec to 2 sec [2] Drone CI server seems happy with the change (I was initially using BuildHive).

Could you please try to revert back to 6 sec to see if it helps? Also make sure to clean target folder.
If not please provide the console log and target/test-elasticsearch-river-mongo.log

[1] - https://drone.io/github.com/richardwilly98/elasticsearch-river-mongodb/latest
[2] - 220e51c#L3L83

@richardwilly98
Copy link
Owner Author

@benmccann still having issues with test failing?

@benmccann
Copy link
Collaborator

Haven't done any development on this in the past couple weeks. I'll be sure to try your suggestion if I run into a test failure again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants