Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change folder for Logs like we did for configurations #58

Closed
richibrics opened this issue Feb 17, 2023 · 1 comment · Fixed by #107 · May be fixed by #61
Closed

Change folder for Logs like we did for configurations #58

richibrics opened this issue Feb 17, 2023 · 1 comment · Fixed by #107 · May be fixed by #61
Labels
feature request request a new feature WIP

Comments

@richibrics
Copy link
Owner

richibrics commented Feb 17, 2023

I wouldn't place them in configurations folders, so I still need to find the correct place.

Logs are currently saved in script folder and this isn't a great way to store them.

@richibrics richibrics linked a pull request Feb 22, 2023 that will close this issue
@infeeeee
Copy link
Collaborator

infeeeee commented Oct 6, 2023

Also logrotation should be handled. IoTuring just creates new logs at each restart, old ones should be deleted.

Python built in logging library has some functions for this: https://docs.python.org/3/library/logging.handlers.html#timedrotatingfilehandler

Maybe we should change to this library from this custom logger?

@richibrics richibrics added feature request request a new feature WIP labels Nov 27, 2023
@infeeeee infeeeee mentioned this issue Nov 27, 2023
@infeeeee infeeeee linked a pull request Jan 12, 2024 that will close this issue
5 tasks
@infeeeee infeeeee mentioned this issue May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request request a new feature WIP
Projects
None yet
2 participants