Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Windows and Mac #26

Closed
Gakk opened this issue Nov 24, 2022 · 5 comments
Closed

Support for Windows and Mac #26

Gakk opened this issue Nov 24, 2022 · 5 comments

Comments

@Gakk
Copy link

Gakk commented Nov 24, 2022

Is your feature request related to a problem? Please describe.

Running this on a Windows and Mac is not supported:
image

Describe the solution you'd like

Either support Windows and Mac or document on readme that this action only supports Linux.

Describe alternatives you've considered
The current alternative is to find another Github action to use 😇

@rickstaa rickstaa changed the title Support for Windows or document Linux only Support for Windows and Mac Dec 10, 2022
@rickstaa
Copy link
Owner

@Gakk (and @ismael-gobernado-deltatre) This is a limitation that is present in the current Github docker actions (see the Github action documentation). I can, however, easily add Windows and Mac support by converting this action into a composite action. What do you think?

I have more pressing deadlines before the new year, but I can release this composite version on https://github.com/rickstaa/action-create-tag-composite somewhere at the start of the new year. 🚀

@Gakk
Copy link
Author

Gakk commented Dec 12, 2022

Thanks for your response @rickstaa.

Instead of using an action I went with just using the GIT command line:

    - name: Tag published version
      run: |
        git tag -a v${{ needs.build.outputs.versionTag }} -m "Published version ${{ needs.build.outputs.versionTag }}" ${GITHUB_SHA}
        git push origin v${{ needs.build.outputs.versionTag }}

If you would like to convert your action into a composite action that is up to you, and thank you for being willing to do so, but I think I will keep using the simple command anyway now that it is implemented.

@rickstaa
Copy link
Owner

Thanks for your response @rickstaa.

Instead of using an action I went with just using the GIT command line:

    - name: Tag published version
      run: |
        git tag -a v${{ needs.build.outputs.versionTag }} -m "Published version ${{ needs.build.outputs.versionTag }}" ${GITHUB_SHA}
        git push origin v${{ needs.build.outputs.versionTag }}

If you would like to convert your action into a composite action, that is up to you, and thank you for being willing to do so, but I think I will keep using the simple command anyway now that it is implemented.

Thanks for letting me know! Yea, the command line is the best way I have used it myself in some projects. Maybe I will document this option instead of creating a composite action. 🤔 If it's okay with you, I would like to keep this issue open for a bit so that I don't forget. 👍🏻

@Gakk
Copy link
Author

Gakk commented Dec 13, 2022

If it's okay with you, I would like to keep this issue open for a bit so that I don't forget. 👍🏻

Please keep it open until documented 🙂👍

@rickstaa
Copy link
Owner

@Gakk I documented this in https://github.com/rickstaa/action-create-tag/releases/tag/v1.5.4 as I currently do not have the time to create a branch with a composite version of this action. If somebody wants to take this on in the future, feel free to create a PR. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants