Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline comments #110

Open
AlexeyTipunin opened this issue Jun 3, 2016 · 4 comments
Open

Inline comments #110

AlexeyTipunin opened this issue Jun 3, 2016 · 4 comments
Assignees
Milestone

Comments

@AlexeyTipunin
Copy link

Hello.

Is any possible to use inline comments like this:

Database = TankBattery # Database name

?
Thenk you.

@rickyah
Copy link
Owner

rickyah commented Jul 21, 2016

@AlexeyTipunin I'm so, so sorry I missed this issue! I remember reading the email notifying this issue but I don't know why I removed from my inbox and then forgot about this. My apologies

On your question:

no, inline comments are NOT supported, but that's a bug, not a feature!

The problem is that the parser supports the comment characters in the middle of keys / values (don't know what was I thinking when I made the parser behave like this 😢) The problem is that changing this behaviour will change the way the parser works and it will break compatibility with previous versions (triggering a new Major version of the lib)

I'll start working on correcting this issue and try to mitigate this behaviour while supporting inline comments, so I can skip a new Major version change.

@Malij75
Copy link

Malij75 commented Sep 8, 2016

Hi,
Please not forget implement Configuration property like AllowInlineComment for turn inline comment search on and off, because sometime it's need to use ";" or "#" as value part

thanks,
Andriy

@rickyah rickyah closed this as completed Dec 5, 2016
@rickyah rickyah reopened this Dec 5, 2016
@rickyah rickyah added this to the v3.0.0 milestone Feb 17, 2017
@rickyah rickyah self-assigned this Feb 22, 2017
@Al12rs
Copy link

Al12rs commented Mar 25, 2019

I second this feature request. A lot of the INI files my application needs to parse will contain inline comments.
Having this in the configuration options would be incredibly helpful.

@bluekms
Copy link

bluekms commented Sep 10, 2024

I need this feature.
When will v3.0.0 be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants