fix: close server on telemetry flush #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## alpha #8 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 6 6
Lines 143 143
Branches 50 47 -3
=======================================
Hits 131 131
Misses 12 12 Continue to review full report at Codecov.
|
ricokahler
force-pushed
the
fix/close-server-on-telemetry-flush
branch
from
479fa82 to
c458dc0
Compare
|
🎉 This PR is included in version 1.1.1-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ricokahler
added a commit
that referenced
this pull request
Mar 18, 2021
* fix: close server on telemetry flush (#8) BREAKING CHANGE: Next.js > 10.0.9 is now required.
ricokahler
added a commit
that referenced
this pull request
Jul 6, 2021
commit 310fe02 Author: Renovate Bot <bot@renovateapp.com> Date: Thu Jul 1 03:33:00 2021 +0000 chore(deps): update dependency next to v11 commit 6629d0c Author: Renovate Bot <bot@renovateapp.com> Date: Thu Jul 1 02:52:08 2021 +0000 chore(deps): update dependency jest to v27 commit de110b8 Author: Renovate Bot <bot@renovateapp.com> Date: Thu Jul 1 01:51:02 2021 +0000 chore(deps): update typescript-eslint monorepo to v4.28.1 commit 9bfeebc Author: Renovate Bot <bot@renovateapp.com> Date: Thu Jul 1 01:48:42 2021 +0000 chore(deps): update dependency semantic-release to v17.4.4 commit 015633e Author: Renovate Bot <bot@renovateapp.com> Date: Thu Jul 1 01:45:56 2021 +0000 chore(deps): update babel monorepo commit 8bc05d4 Author: Renovate Bot <bot@renovateapp.com> Date: Thu Jul 1 00:56:11 2021 +0000 chore(deps): update all commit f0fa1fa Author: Renovate Bot <bot@renovateapp.com> Date: Tue Jun 1 02:41:51 2021 +0000 chore(deps): update dependency @rollup/plugin-node-resolve to v13 commit 1cbdc2f Author: Renovate Bot <bot@renovateapp.com> Date: Tue Jun 1 02:39:37 2021 +0000 chore(deps): update typescript-eslint monorepo to v4.26.0 commit 1e2271d Author: Renovate Bot <bot@renovateapp.com> Date: Tue Jun 1 01:26:57 2021 +0000 chore(deps): update all commit f41fd3c Author: Renovate Bot <bot@renovateapp.com> Date: Tue Jun 1 01:24:46 2021 +0000 chore(deps): update dependency semantic-release to v17.4.3 commit e4fdcf7 Author: Renovate Bot <bot@renovateapp.com> Date: Tue Jun 1 01:22:02 2021 +0000 chore(deps): update dependency next to v10.2.3 commit 880e180 Author: Renovate Bot <bot@renovateapp.com> Date: Tue Jun 1 00:09:57 2021 +0000 chore(deps): update babel monorepo commit d82b38e Author: Guilherme Duarte <gjsduarte@gmail.com> Date: Fri May 14 20:42:47 2021 +0100 fix: Add options to server cache key invocation (#18) commit 882cb1c Author: Renovate Bot <bot@renovateapp.com> Date: Sat May 1 05:43:38 2021 +0000 chore(deps): update dependency semantic-release to v17.4.2 commit 4c7ca31 Author: Renovate Bot <bot@renovateapp.com> Date: Sat May 1 03:33:58 2021 +0000 chore(deps): update dependency next to v10.2.0 commit 5268a24 Author: Renovate Bot <bot@renovateapp.com> Date: Sat May 1 01:31:37 2021 +0000 chore(deps): update babel monorepo commit 7e803aa Author: Renovate Bot <bot@renovateapp.com> Date: Sat May 1 00:10:55 2021 +0000 chore(deps): update all commit c05e451 Author: Renovate Bot <bot@renovateapp.com> Date: Thu Apr 1 08:25:16 2021 +0000 chore(deps): update actions/setup-node action to v2 commit b7cc7ef Author: Renovate Bot <bot@renovateapp.com> Date: Thu Apr 1 04:15:11 2021 +0000 chore(deps): update babel monorepo commit b1c766b Author: Renovate Bot <bot@renovateapp.com> Date: Thu Apr 1 02:37:20 2021 +0000 chore(deps): update all commit ab59eac Author: Renovate Bot <bot@renovateapp.com> Date: Thu Apr 1 00:12:35 2021 +0000 chore(deps): pin dependencies commit 5f0096a Author: Rico Kahler <rakahler@umich.edu> Date: Thu Mar 18 13:17:29 2021 -0400 Update README.md commit 5801b98 Author: Rico Kahler <rakahler@umich.edu> Date: Thu Mar 18 03:25:39 2021 -0400 release 2.0 (#9) * fix: close server on telemetry flush (#8) BREAKING CHANGE: Next.js > 10.0.9 is now required.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7
The solution here was to hi-jack the telemetry flush call to give us an event to close the server.