Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPageModelCoreMethods missing method PushPageModel(Type pageModelType, object data, bool modal = false, bool animate = true) #299

Open
josh-cunningham opened this issue Dec 24, 2019 · 1 comment

Comments

@josh-cunningham
Copy link

The PushPageModel method that allows us to use page model type argument with data is missing from the Core Methods interface.
I am using the latest nuget package.
I have added the following extension method successfully so it appears to just be an issue with the interface, unless I'm missing something.
Thanks.

public static async Task PushPageModel(this IPageModelCoreMethods iCoreMethods, Type pageModelType, object data, bool modal = false, bool animate = true)
{
    var coreMethods = (PageModelCoreMethods)iCoreMethods;
    await coreMethods.PushPageModel(pageModelType, data, modal, animate);
}
@joanbarros
Copy link

joanbarros commented Mar 2, 2020

I'm seeing this same issue. It's as if the NuGet version is out of date... Or the code in master is not the one used to build the NuGet package.

This line:

Task PushPageModel (Type pageModelType, object data, bool modal = false, bool animate = true);

Is not present in the interface I have in my project (NuGet v3.0.0).

UPDATE:

If I reference the implementation directly the method is found:

await ((FreshMvvm.PageModelCoreMethods)CoreMethods).PushPageModel(pageModelType, data);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants