-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for extensions #52
Comments
@KrzysztofZawisla What if you provide an array of strings? Can add type support as well, but that should work in the meantime unless I'm horribly wrong. |
@KrzysztofZawisla Added to #53, if you'd like to test, otherwise I'll have this merged in tomorrow! :) |
Has been merged and released in v1.8.4 |
Sorry, I was out of programming vibe for these 4 days, so I didn't even check replies on this issue. It's important to not have items in array as string, because they will also be evaluated to string in prisma schema. Prisma requires passing extensions not as string to properly highlight syntax. In free time I will check the new release if it solves that problem. |
@KrzysztofZawisla Thanks for letting me know! I'll make this adjustment tonight. |
@KrzysztofZawisla Alright, #54 should address this fair and square. I was actually looking at the project you're contributing to the other day that implemented Schemix, and was impressed by the scale at which you guys took the library. Was very happy to see that. Since you guys are really using the library well, if you have any other suggestions, feature requests, or bug reports, let me know and I'll be sure to address them as soon as I can. Since you guys are using MongoDB, I'd love to pull some of the situations where you might have to create wrapper functions or use Anywho, feel free to review #54, otherwise I'll have it merged in today or tomorrow. |
Released in v1.8.5 since the change does not touch any other components, let me know if that addresses that and I will close this issue. |
@ridafkih I have checked the new release (1.8.5) and everything works perfectly good. I'm also happy about the fact that you have created that library, and we found it. Unique and well-done documented library in this field. Our Prisma schema expanded dramatically, and we thought that have to be separated + we had issues with stuff that must have done programmatically like country codes or enums generated based on typescript enums. We will make a PR or report issue in case when we will found a way to improvement something, but firstly we need to make our PostgreSQL, MongoDB, and FaunaDB schemas/structure and migrations 😅. Best Regards, |
https://www.prisma.io/docs/concepts/components/prisma-schema/postgresql-extensions
With the current implementation, this code:
Evaluates to:
The text was updated successfully, but these errors were encountered: