Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from Rc to Arc for handles #10

Closed
1 task
vickles opened this issue Aug 30, 2020 · 1 comment · Fixed by #34
Closed
1 task

Move from Rc to Arc for handles #10

vickles opened this issue Aug 30, 2020 · 1 comment · Fixed by #34
Labels
C-All enhancement New feature or request
Milestone
0.1

Comments

@vickles
Copy link
Collaborator

vickles commented Aug 30, 2020 •
edited
Loading

Switch from Rc to Arc where possible for handles throughout riddle. Take advantage of Arc::new_cyclic to make it neater to hide away the Arc in the public API.

Required lang features
@vickles vickles added enhancement New feature or request C-All labels Aug 30, 2020
@vickles vickles modified the milestones: 0.2, Blocked Aug 30, 2020
@vickles vickles mentioned this issue Sep 15, 2020
Merged
@vickles vickles modified the milestones: Blocked, 0.1 Sep 15, 2020
@vickles
Copy link
Collaborator Author

vickles commented Sep 15, 2020

Committing to going nightly only for now in order to get this in for milestone 0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-All enhancement New feature or request
Projects
None yet
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

Rc to arc riddle-rs/riddle
1 participant
@vickles