Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RiemannReporter does not close connection to Riemann server when it's told to stop() #65

Open
mallman opened this issue Nov 25, 2015 · 0 comments
Open

RiemannReporter does not close connection to Riemann server when it's told to stop() #65

mallman opened this issue Nov 25, 2015 · 0 comments

Comments

@mallman
Copy link
Contributor

mallman commented Nov 25, 2015

RiemannReporter (https://github.com/aphyr/riemann-java-client/blob/c7ef74cdae1cd53a66395d13fbf1ae0a5a81244e/metrics3-riemann-reporter/src/main/java/com/codahale/metrics/riemann/RiemannReporter.java) needs to override the stop() method of ScheduledReporter to close the Riemann server connection it holds. Otherwise, it leaves a dangling connection and non-daemon thread which prevents application termination.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mallman