Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve blocking channel #77

Open
Jan21493 opened this issue Sep 7, 2024 · 0 comments
Open

Resolve blocking channel #77

Jan21493 opened this issue Sep 7, 2024 · 0 comments

Comments

@Jan21493
Copy link

Jan21493 commented Sep 7, 2024

@wimaha found a bug in glatt.go in Connect function. Originally in go-ble/ble#112, but I'm not sure if that repository is really active. I have the same issue, but have switched to this repository some time ago.

Here's a short description of the bug:
When a device can't be found, normally ctx2 fires bevor ctx, so that the function Scan returns context deadline exceeded.

Sometimes (rarely but randomly) ctx fires and cancels ctx2 (see line 131). In this case Scan return with context canceled. This yields to the line 147 cln, err := Dial(ctx, (<-ch).Addr()) is executed and ist blocking, because of (<-ch).Addr().

For this case I propose a simple fix with a PR #76

The issue occurs, if a specific BLE beacon that I'm looking for, can't be found. I'm using the ble package with a cmd tool from Teslamotors (https://github.com/teslamotors/vehicle-command/tree/main/cmd/tesla-control) to verify if my Tesla is at home. When the car is at home, everything works fine, but if the car is away then the tool hangs / does not return from time to time. I'm calling the tool from a script every minute and it may take some minutes or hours after the issue occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant