Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all dotvvm internal routes to the /_dotvvm/ prefix #1539

Open
exyi opened this issue Dec 27, 2022 · 1 comment · May be fixed by #1895
Open

Move all dotvvm internal routes to the /_dotvvm/ prefix #1539

exyi opened this issue Dec 27, 2022 · 1 comment · May be fixed by #1895
Assignees
Milestone

Comments

@exyi
Copy link
Member

exyi commented Dec 27, 2022

Currently, we internally use a lot of different endpoints (dotvvmResource, something for file upload, returned files, ...). The new things, like configuration page are under /_dotvvm prefix, so it would make sense to move everything else into that directory too.

This will make it easier to whitelist all dotvvm requests, avoid conflicts on websites with a /{username} route (like github, twitter does), and feel less adhoc in general.

It's breaking, there are definitely people hardcoding dotvvmResource somewhere, but I don't think it's common

@exyi exyi added this to the Version 5.0 milestone Dec 27, 2022
@exyi
Copy link
Member Author

exyi commented Jan 3, 2023

Actually, .dotvvm could be a better choice, in the style of .well-known. Underscore tends to be a valid character in names more often than the dot.

@exyi exyi changed the title Move all dotvvm internal routes to the /_dotvvm/ directory Move all dotvvm internal routes to the /_dotvvm/ prefix Jul 26, 2023
@exyi exyi self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant