Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining time display #644

Closed
Dendraspis opened this issue Nov 13, 2024 · 4 comments
Closed

Remaining time display #644

Dendraspis opened this issue Nov 13, 2024 · 4 comments

Comments

@Dendraspis
Copy link
Contributor

Dendraspis commented Nov 13, 2024

Hello rigaya,

sorry for that one, but it seems like this code adding 500(ms?) to the remaining time...

uint32_t remaining_time = (uint32_t)(elapsedTime * (100.0 - progressPercent) / progressPercent + 0.5);
const int hh = remaining_time / (60*60*1000);
remaining_time -= hh * (60*60*1000);
const int mm = remaining_time / (60*1000);
remaining_time -= mm * (60*1000);
const int ss = (remaining_time + 500) / 1000;
chunks[MES_PROGRESS_PERCENT].len = _stprintf_s(chunks[MES_PROGRESS_PERCENT].str, _T("[%.1lf%%] "), progressPercent);
chunks[MES_REMAIN].len = _stprintf_s(chunks[MES_REMAIN].str, _T(", remain %d:%02d:%02d"), hh, mm, ss);

...leads sometimes to an output of something like: remain 0:10:60, which can be pretty annoying. Don't know if you want to improve it...
At least it has been reported to me twice already.

PS: Don't beat me for that. 😅

@rigaya
Copy link
Owner

rigaya commented Nov 14, 2024

which can be pretty annoying

really?

I might remove +500 in the future.

@Dendraspis
Copy link
Contributor Author

I looks pretty weird, but absolute minor ... just wanted to report it anyway. 😅

@rigaya
Copy link
Owner

rigaya commented Nov 22, 2024

+500 has been removed in NVEnc 7.75.

@Dendraspis
Copy link
Contributor Author

Then we can definitely close this issue...

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants