Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases for runtime #846

Merged
merged 10 commits into from
Sep 5, 2022
Merged

Releases for runtime #846

merged 10 commits into from
Sep 5, 2022

Conversation

begelundmuller
Copy link
Contributor

No description provided.

@begelundmuller
Copy link
Contributor Author

begelundmuller commented Aug 31, 2022

These builds give unstable binaries on macOS. Seems like they crash on C++ exceptions, even when they are handled. Looks similar to the bug addressed in sqldef/sqldef#272

Issues to track in Zig:

Proposed quick fix: Don't use Zig for macOS builds just yet. But Zig still looks promising, so we can move back when the above issues are resolved.

@begelundmuller begelundmuller marked this pull request as ready for review September 5, 2022 09:19
@begelundmuller begelundmuller merged commit 88b3c38 into main Sep 5, 2022
@begelundmuller begelundmuller deleted the runtime-release branch September 5, 2022 09:47
@kubkon
Copy link

kubkon commented Jan 24, 2023

These builds give unstable binaries on macOS. Seems like they crash on C++ exceptions, even when they are handled. Looks similar to the bug addressed in k0kubun/sqldef#272

Issues to track in Zig:

* [C++: wrong exception handling with std::stoi on non-debug builds ziglang/zig#10892](https://github.com/ziglang/zig/issues/10892)

* [zig c++: Unwinding across shared library boundaries doesn't work ziglang/zig#11422](https://github.com/ziglang/zig/issues/11422)

Proposed quick fix: Don't use Zig for macOS builds just yet. But Zig still looks promising, so we can move back when the above issues are resolved.

Sorry for just dropping a message out-of-the-blue, but I followed a linked conversation by @motiejus, the MachO linker in Zig since a week or so can now handle C++ exceptions (or unwind info in general): ziglang/zig#14397. ziglang/zig#11422 is still an open issue due to Zig compiling and linking statically libc++ I believe and I will get on it soon enough.

@begelundmuller
Copy link
Contributor Author

Thank you @kubkon, that's awesome!

djbarnwal pushed a commit that referenced this pull request Aug 3, 2023
* Include Rill SQL in runtime binary

* Cross-platform runtime build

* Fix binary extension for windows

* Fix typo in windows binary extension

* Run runtime builds on macos

* Fix bad path in runtime release ci

* Move darwin builds off Zig

* Use runtime service account
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants