Skip to content

Commit 42bacc5

Browse files
committed
fix(rime_levers_api.h): customize_bool() misused bool type
BREAKING CHANGE: in signature of C API function `customize_bool()`, change type `bool` to `Bool` (alias of `int`). Impact: the changed function is not in use by any first party code, known to be in use by osfans/trime.
1 parent 2a15ef4 commit 42bacc5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/rime/lever/levers_module.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ static Bool rime_levers_save_settings(RimeCustomSettings* settings) {
6363
}
6464

6565
static Bool rime_levers_customize_bool(RimeCustomSettings* settings,
66-
const char* key, bool value) {
67-
an<ConfigItem> item = New<ConfigValue>(value);
66+
const char* key, Bool value) {
67+
an<ConfigItem> item = New<ConfigValue>(bool(value));
6868
auto custom_settings = reinterpret_cast<CustomSettings*>(settings);
6969
return custom_settings->Customize(key, item);
7070
}

src/rime_levers_api.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ typedef struct rime_levers_api_t {
3232
void (*custom_settings_destroy)(RimeCustomSettings* settings);
3333
Bool (*load_settings)(RimeCustomSettings* settings);
3434
Bool (*save_settings)(RimeCustomSettings* settings);
35-
Bool (*customize_bool)(RimeCustomSettings* settings, const char* key, bool value);
35+
Bool (*customize_bool)(RimeCustomSettings* settings, const char* key, Bool value);
3636
Bool (*customize_int)(RimeCustomSettings* settings, const char* key, int value);
3737
Bool (*customize_double)(RimeCustomSettings* settings, const char* key, double value);
3838
Bool (*customize_string)(RimeCustomSettings* settings, const char* key, const char* value);

0 commit comments

Comments
 (0)