Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrBitStateNotFound error is missing #11

Closed
yaronius opened this issue Jan 11, 2021 · 1 comment
Closed

ErrBitStateNotFound error is missing #11

yaronius opened this issue Jan 11, 2021 · 1 comment

Comments

@yaronius
Copy link

Hi! I come from an older version of this library which was github.com/snowman-mh/device-check-go and it is redirecting me to this repo now. And I see that the older version was using ErrBitStateNotFound which is missing in this repository. The only trace of this error is found in README and is kind of misleading because the SDK doesn't return this error now:

if err := client.QueryTwoBits("DEVICE_TOKEN_FROM_CLIENT", &result); err != nil {
	// error handling
	// Note that SDK returns ErrBitStateNotFound error if no bits found
}

What would be a suitable replacement for this error in the current version of SDK? I browsed the code and didn't find any. It would be nice to update the README as well.

@rinchsan
Copy link
Owner

rinchsan commented Jan 13, 2021

@yaronius
Thank you for filing a bug!

This issue was fixed by #12 (thanks to @peter-meemo) and some more tests were added by #13 .
And I released a new version https://github.com/rinchsan/device-check-go/releases/tag/v1.2.0 including above bug fixes.

Feel free to re-open this or open a new one if you find any degradations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants