Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cancellable (or custom) context.Context #16

Closed
rinchsan opened this issue Jan 19, 2021 · 0 comments · Fixed by #34
Closed

Support cancellable (or custom) context.Context #16

rinchsan opened this issue Jan 19, 2021 · 0 comments · Fixed by #34

Comments

@rinchsan
Copy link
Owner

rinchsan commented Jan 19, 2021

  • Want to support cancellable (or custom) context.Context for http requests
  • Going to be a major release of v2
    • Create /v2 directory and copy existing files to the directory, and then support cancellable context.Context only in /v2 ? (according to the official go documentation)
    • https://blog.golang.org/v2-go-modules
  • Pass ctx context.Context as a first argument for query/update/validate methods
    • then pass it to api.do as a first argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant