Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two new functions to JSGI response module #371

Closed
botic opened this issue May 2, 2017 · 2 comments · Fixed by #373
Closed

Add two new functions to JSGI response module #371

botic opened this issue May 2, 2017 · 2 comments · Fixed by #373
Labels
javascript
Milestone
1.2

Comments

@botic
Copy link
Member

botic commented May 2, 2017 •
edited
Loading

  • setHeaders() like addHeaders(), but with an overriding behaviour
  • setContentType() to set the mime type of a response

Both will help to keep the API fluent.
@botic botic added this to the 1.2 milestone May 2, 2017
@botic
Copy link
Member Author

botic commented May 12, 2017

@oberhamsi @grob What do you think? Anything else missing from your pov? You worked on a lot of API stuff and there this two functions might help a lot.

@grob
Copy link
Member

grob commented May 13, 2017

both make sense, so 👍

@botic botic mentioned this issue Jul 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
javascript
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Add new helpers to JSGI response module ringo/ringojs
2 participants
@grob @botic