Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need a built-in yaml filter? #1002

Closed
Kijewski opened this issue Apr 6, 2024 · 4 comments · Fixed by #1003
Closed

Do we need a built-in yaml filter? #1002

Kijewski opened this issue Apr 6, 2024 · 4 comments · Fixed by #1003

Comments

@Kijewski
Copy link
Collaborator

Kijewski commented Apr 6, 2024

I don't really see a compelling use case for a built-in yaml filter. It's a serialization format widely used for input configurations, not for generated web output. The feature was asked for in #192, and it was added in #201.

The package serde_yaml is now marked as deprecated and unmaintained by its author. If we keep the feature, then maybe we should look around if there is an active fork of the project?

Cc @antifuchs.

@GuillaumeGomez
Copy link
Collaborator

I think it's "easy enough" to add your own yaml filter if needed. Seems to be out of scope of askama.

@djc
Copy link
Collaborator

djc commented Apr 6, 2024

That's fair -- let's kill it.

@GuillaumeGomez
Copy link
Collaborator

Sending a PR to remove it then. :3

@antifuchs
Copy link

Fine by me to kill the feature - I honestly had to look up what askama even was, it's been so long that I used the tool that I built using it ((:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants