Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayHistory track artists images is always null #133

Open
idanmaman2 opened this issue Oct 17, 2022 · 2 comments
Open

PlayHistory track artists images is always null #133

idanmaman2 opened this issue Oct 17, 2022 · 2 comments
Labels

Comments

@idanmaman2
Copy link

hi , when I fetch from recentlyplayed and get Iterable of PlayHistory the artist image is null , plz fix it ,
Best regards and thanks for the package Idan .

@rinukkusu
Copy link
Owner

Looking at the docs it seems Spotify doesn't return a full Artist object, but rather just the ArtistSimple one, which doesn't contain an artist image.

Screenshot from when executing the endpoint in the developer console:

grafik

The fix for us is: use the simple class instead of the full artist class.

The fix for you is: grab each artist with spotify.artists.get('<id>'); or spotify.artists.list([<id1>, <id2>, ...]);

Thanks for bringing it to our attention!

@rinukkusu rinukkusu added the bug label Oct 18, 2022
@rinukkusu
Copy link
Owner

Looking again, the docs don't clearly state what should be returned in the recentlyPlayed endpoint and even just getting a track didn't return the full artist object, even though the docs state it should be returned. Maybe not a bug and just Spotify API weirdness ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants