Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem after upgrading to Chromium v55.0.2883.87 #28

Open
seth100 opened this issue Dec 20, 2016 · 3 comments
Open

Problem after upgrading to Chromium v55.0.2883.87 #28

seth100 opened this issue Dec 20, 2016 · 3 comments

Comments

@seth100
Copy link

seth100 commented Dec 20, 2016

Hi,

I was used to run my cordova project on Chromium using Ripple.
After upgrading to Chromium v55.0.2883.87 I get this error:

Uncaught TypeError: Cannot read property 'split' of undefined
    at initialize.onImageLoad (ripple.js:20)
    at HTMLImageElement.<anonymous> (ripple.js:13)
onImageLoad @ ripple.js:20
(anonymous) @ ripple.js:13

and some of the button on my app are not working.
It happens only on Chromium, everything works in Firefox v50.

What do you think?
Is anybody having the same issue?

Thanks

@TimBarham
Copy link
Member

Hmmm, I'm on the same build and not able to repro. Looking at the Ripple source, that it looks like the failure you are seeing is in the OpenLayers.js library (which Ripple uses for the map on the geolocation panel), and the only call to split() in onImageLoad() is a call to navigator.appVersion.split - and navigator.appVersion should never be undefined (though Ripple does replace the navigator object, so perhaps something new in Chrome has broken that).

Some questions:

  • What OS?
  • Does this repro for any Cordova project? Completely new/blank Cordova project?
  • Could you try cordova-simulate to see if you see the same error (it uses the same version of the OpenLayers.js library)? Install (npm install -g cordova-simulate) then, from the command line in your Cordova project, simulate <platform> (where <platform> is the Cordova platform you want to simulate).

@TimBarham
Copy link
Member

Oh, also, what version of Ripple? (run ripple version at the command line)

@seth100
Copy link
Author

seth100 commented Dec 21, 2016

Hi,
thanks for your answer.

  • Ripple version: 0.9.36;
  • OS: Linux Mint 18.1;
  • Yes, it does reproduce for a new blank Cordova project;
  • I tried simulate android --target=chromium and I don't have that error. But still some buttons on my app do not work as it was using Ripple. So maybe it's something about the new Chromium code?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants