Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document nightly toolchain requirement #58

Closed
stefnotch opened this issue Jan 5, 2024 · 5 comments
Closed

Document nightly toolchain requirement #58

stefnotch opened this issue Jan 5, 2024 · 5 comments

Comments

@stefnotch
Copy link

I think it'd be worthwhile to document that this crate requires a nightly Rust toolchain for the time being

nodit/src/lib.rs

Lines 377 to 379 in fac00b8

#![feature(let_chains)]
#![feature(btree_cursors)]
#![feature(step_trait)]

@ripytide
Copy link
Owner

ripytide commented Jan 5, 2024

I just checked and we're not actually using btree_cursors or step_trait anymore, it's unfortunate there doesn't seem to be a lint for unused features. Regarding let_chains I use them twice so it may be better so simply refactor those to use normal match statements and allow this library to be used on stable.

@stefnotch
Copy link
Author

Oh sweet, I had no idea it'd be this easy to get this library to run on stable Rust.

Would you like to do the refactors, or should I?

@ripytide
Copy link
Owner

ripytide commented Jan 5, 2024

I'll do them/already done them just testing them on stable now.

@ripytide
Copy link
Owner

ripytide commented Jan 5, 2024

released as v0.7.1

@stefnotch
Copy link
Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants