Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Missing documentation for Instr Attributes #57

Open
cmuellner opened this issue Mar 21, 2023 · 1 comment
Open

Missing documentation for Instr Attributes #57

cmuellner opened this issue Mar 21, 2023 · 1 comment

Comments

@cmuellner
Copy link
Contributor

The following instruction attributes are not documented (see https://riscv-ctg.readthedocs.io/en/latest/overview.html#attributes):

  • std_op
  • sig and its subfields stride and sz

Further, the example has the following template:

  template: |

    // $comment
    // opcode: $inst ; op1:$rs1; op2:$rs2; dest:$rd; op1val:$rs1_val;  op2val:$rs2_val
    TEST_RR_OP($inst, $rd, $rs1, $rs2, $correctval, $rs1_val, $rs2_val, $swreg, $offset, $testreg)

However, a |- should be there instead of the |.

Additionally, the order of attributes does not match the order used in most templates.

@pawks
Copy link
Collaborator

pawks commented Mar 22, 2023

The following instruction attributes are not documented (see https://riscv-ctg.readthedocs.io/en/latest/overview.html#attributes):

* `std_op`

* `sig` and its subfields `stride` and `sz`

However, a |- should be there instead of the |.

Noted. Documentation needs to be updated with this information.

Additionally, the order of attributes does not match the order used in most templates.

The order of attributes does not matter because these are serialized as a dictionary entry(key-value pairs).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants