Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruamel.yaml deprecated method and silent failing #91

Open
benoitdenkinger opened this issue Jun 19, 2024 · 2 comments
Open

ruamel.yaml deprecated method and silent failing #91

benoitdenkinger opened this issue Jun 19, 2024 · 2 comments

Comments

@benoitdenkinger
Copy link

benoitdenkinger commented Jun 19, 2024

riscv_isac package is not compatible with ruamel.yaml version > 0.18.0 (current latest version is 0.18.6) because of the deprecated method:

AttributeError: 
"round_trip_dump()" has been removed, use

  yaml = YAML()
  yaml.dump(...)

It could be nice to update the dependency on the ruamel.yaml version
ruamel.yaml>=0.16.0,<=0.18.0

If this makes sense, I'll be happy to propose a PR

@benoitdenkinger
Copy link
Author

Actually the version should be lower than 0.18.0, for some reason the output of round_trip_dump() method is different starting from 0.18.0 and the generated cgf file for each test is empty. The latest 0.17.40 version works for me.

As a side note, debugging this problem was really a nightmare as no error was triggered from this empty generated cgf file. I used riscv-isac from riscof (riscof coverage ...) and targets from the generated makefile were failing. Launching the targets on my own, they were failing but silently (so I thought everything was fine at first). Actually the Data Propagation Report and the Report File generation were not triggered because of the emtpy ref.cgf file. The makefile target somehow catches this problem (but without any relevant debug/error information) while running the command directly in the terminal didn't output any error.

@benoitdenkinger benoitdenkinger changed the title ruamel.yaml deprecated method ruamel.yaml deprecated method and silent failing Jun 19, 2024
@allenjbaum
Copy link
Collaborator

Hmm, this has been ignored a bit too long. please propose a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants