Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can "profiles" get a "kind" field, too? #317

Closed
ThinkOpenly opened this issue Nov 26, 2024 · 2 comments · Fixed by #350
Closed

Can "profiles" get a "kind" field, too? #317

ThinkOpenly opened this issue Nov 26, 2024 · 2 comments · Fixed by #350
Labels
enhancement New feature or request

Comments

@ThinkOpenly
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
I wrote a short Python script to read in all of the YAML files in the project for the purposes of verifying content, like what extensions are referenced, but never defined. The specific YAML files that reference extensions are (at least) instructions, extensions, CSRs, and profiles. The first three have a "kind" field identifying what each YAML represents, but the latter, "profiles", does not. Current "kind" fields are:

$ find . -name '*.yaml' -exec grep 'kind:' {} \; | sort -u
kind: certificate class
kind: certificate model
kind: csr
kind: extension
kind: instruction

Describe the solution you'd like
I'd like to see the YAML files describing profiles also have a kind field like:

kind: profile

Describe alternatives you've considered
It's actually difficult to work around, because the top-level field is a profile name, so not a consistent key that can be checked for existence.

@ThinkOpenly ThinkOpenly added the enhancement New feature or request label Nov 26, 2024
@dhower-qc
Copy link
Collaborator

Yes, that's the plan. The only reason it isn't done now is because @dlweaver is working on RVA23; I didn't want to interfere with the schema until he is ready.

@dhower-qc dhower-qc reopened this Dec 4, 2024
@dlweaver
Copy link
Collaborator

dlweaver commented Dec 4, 2024

If all it takes is adding a "kind: profile" field to RVB23 and RVA23, I can do that right away. Just let me know. (RVB23 is mostly done; probably won't start on RVA23 until early next week)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants