Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to disable tlbs #182

Open
neelgala opened this issue Sep 12, 2022 · 4 comments
Open

switch to disable tlbs #182

neelgala opened this issue Sep 12, 2022 · 4 comments
Labels
configuration Additional configuration settings needed for the model tgmm-agenda Tagged for the next Golden Model meeting agenda.

Comments

@neelgala
Copy link

I believe there is some sort of a TLB like structure used in SAIL which prevents PTW to be triggered for each memory/instruction access. It would be beneficial if we can have a switch via the cli to disable the TLBs so that all memory/instruction accesses undergo a PTW by default.

This requirement comes from the SIG-ACT with regards to capturing ISA coverage for tests dealing with translation schemes.

@martinberger
Copy link
Collaborator

@Timmmm Timmmm added the configuration Additional configuration settings needed for the model label May 7, 2024
@Timmmm
Copy link
Collaborator

Timmmm commented Dec 30, 2024

Can you explain more why this is needed (assuming it still is). If tests want to guarantee a page table walk can't they just do an sfence.vma? Doesn't seem like the ACTs should rely on microarchitectural details about the TLB.

@allenjbaum
Copy link
Collaborator

Good question. ACTs are trying to avoid microarchitectural details (e.g the presence of a TLB or it's organization and behavior), not rely on them. I think it was to ensure that certain implicit accesses were made properly (i.e.the full table walk). Yes, we could modify the tests to add the fence op, but it would be a lot of work.
If this has already been implemented, I'd rather it continue for now, and I'll file an issue to add the fence.vma before every test access for the VMM tests. And

@Timmmm
Copy link
Collaborator

Timmmm commented Jan 3, 2025

I think I'd be more in favour of just fixing the tests, but I'm not sure I fully understand the issue. I'll tag this for discussion in the meeting.

@Timmmm Timmmm added the tgmm-agenda Tagged for the next Golden Model meeting agenda. label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Additional configuration settings needed for the model tgmm-agenda Tagged for the next Golden Model meeting agenda.
Projects
None yet
Development

No branches or pull requests

4 participants