Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WithOptions with deserialize_with but not default are actually required #18284

Open
xiangjinwu opened this issue Aug 28, 2024 · 0 comments
Open

WithOptions with deserialize_with but not default are actually required #18284

xiangjinwu opened this issue Aug 28, 2024 · 0 comments
Assignees
@StrikeW
Labels
component/doc Issues about documentation.
Milestone
release-2.2

Comments

@xiangjinwu
Copy link
Contributor

It seems only required when using deserialize_with. We will see if we can fix the required: false in yaml.

Originally posted by @xiangjinwu in #18261 (comment)

Goals:

  • When deserialize_with is used without default, generate required: true
  • Better: issue a warning to remind developers to add default.
@github-actions github-actions bot added this to the release-2.1 milestone Aug 28, 2024
@fuyufjh fuyufjh modified the milestones: release-2.1, release-2.2 Oct 17, 2024
@fuyufjh fuyufjh added the component/doc Issues about documentation. label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StrikeW StrikeW

Labels
component/doc Issues about documentation.
Projects
None yet
Milestone
release-2.2
Development

No branches or pull requests
3 participants
@StrikeW @fuyufjh @xiangjinwu